Skip to content

[13.0][FIX] account: don't set exclude_from_invoice_tab for type entry - #4385

Merged
pedrobaeza merged 1 commit into
OCA:13.0from
hbrunn:13.0-account-exclude_from_invoice_tab-entry
Apr 9, 2024
Merged

[13.0][FIX] account: don't set exclude_from_invoice_tab for type entry#4385
pedrobaeza merged 1 commit into
OCA:13.0from
hbrunn:13.0-account-exclude_from_invoice_tab-entry

Conversation

@hbrunn

@hbrunn hbrunn commented Apr 8, 2024

Copy link
Copy Markdown
Member

when we create an entry in v13, this flag isn't set on move lines for type entry, so the migration shouldn't set it either. Otherwise, we get weird side effects when recomputing ie the balance of such entries

@pedrobaeza

Copy link
Copy Markdown
Member

I don't get the need of this. exclude_from_invoice_tab=True is the default value for everything except the invoice lines, so when move_type = entry, they should be that value too.

@hbrunn

hbrunn commented Apr 9, 2024

Copy link
Copy Markdown
Member Author

this one I found on the way to #4386 - we don't exactly need it, but being closer to what the target version does is better, right?

For demonstration, I've just created a move on runboat

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I see that indeed Odoo doesn't care about such flag when the move type is entry:

imagen

@pedrobaeza
pedrobaeza merged commit 39543a8 into OCA:13.0 Apr 9, 2024
@hbrunn

hbrunn commented Apr 9, 2024

Copy link
Copy Markdown
Member Author

I added the column at the beginning ;-)

@pedrobaeza

Copy link
Copy Markdown
Member

Hehe, didn't see it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants